openstack-k8s-operators / edpm-ansible

External Dataplane Management Ansible Playbooks
https://openstack-k8s-operators.github.io/edpm-ansible/
Apache License 2.0
9 stars 66 forks source link

nmstate and edpm_network_config_update #820

Open dudy-duce opened 1 week ago

dudy-duce commented 1 week ago

Hello,

When using edpm_network_config_tool: nmstate, there is no trace of a potential previous execution as is done with os-net-config. Therefore, the variable edpm_network_config_update does not work when using nmstate and the network system role so network configuration is updated at every run.

Thanks

slagle commented 6 days ago

Thanks for reporting this issue. I've filed it here: https://issues.redhat.com/browse/OSPRH-11795

rabi commented 4 days ago

Did you try using the nmstate provider with os-net-config instead? i.e Don't change edpm_network_config_tool ansible var, but set edpm_network_config_nmstate: true. I think os-net-config has support for nmstate config and it's now the default provider[1]. Looks like os-net-config-18.0.1 ships with OSP18 and the feature may work.

[1] https://github.com/os-net-config/os-net-config/commit/5d6a3ca608112354b11256ca5fee934ecf34b236

dudy-duce commented 4 days ago

Thank you for your feedback. I know it works with os-net-config, and I'm not looking for a workaround. I opened this issue to highlight a problem when using nmstate, aiming to improve its usage through the RHEL system role network and potentially make it the default provider in the future. I don't believe this would require a significant development effort, and I’m willing to contribute if you’re interested.

rabi commented 1 day ago

OK. I think the current plan is to use os-net-config as the wrapper tool with different providers, for both native(os-net-config config) and nmstate config, though it would be good to support the same behavior with RHEL system role. Feel free to contribute.