search

openstack-k8s-operators / horizon-operator

Apache License 2.0
1 stars 26 forks source link

[pre-commit][kuttl]Check for multiple TestAssertsh #321

Closed gibizer closed 6 months ago

gibizer commented 6 months ago

Add a new pre-commit check to avoid using more than one TestAssert in a single kuttl assert file as that can lead to false positives as only the last TestAssert is run by kuttl.

Fortunately there was no such issue in this repo.

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, gibizer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/horizon-operator/blob/main/OWNERS)~~ [abays] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment