search

openstack-k8s-operators / horizon-operator

Apache License 2.0
1 stars 26 forks source link

Fix basic-deployment kuttl assert #366

Closed ashu-011 closed 1 month ago

ashu-011 commented 1 month ago

Currently the way kuttl test is written , it will still pass if no status code is returned as script doesn't have proper exit mechanism to handle that . This PR fixes that and introduce proper error message . Also fixes the command to run in required namespace .

bshephar commented 1 month ago

/test openstack-operator-build-deploy-kuttl

openshift-ci[bot] commented 1 month ago

@bshephar: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openstack-k8s-operators/horizon-operator/pull/366#issuecomment-2363323270): >/test openstack-operator-build-deploy-kuttl Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
bshephar commented 1 month ago

/test horizon-operator-build-deploy-kuttl

ashu-011 commented 1 month ago

/test horizon-operator-build-deploy-kuttl

ashu-011 commented 1 month ago

/test horizon-operator-build-deploy-kuttl

ashu-011 commented 1 month ago

/test horizon-operator-build-deploy-kuttl

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashu-011, bshephar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/horizon-operator/blob/main/OWNERS)~~ [bshephar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment