openstack-k8s-operators / horizon-operator

Apache License 2.0
1 stars 26 forks source link

Use new nad.EnsureNetworksAnnotation() func to get NAD annotations #387

Closed stuggi closed 4 hours ago

stuggi commented 23 hours ago

For BGP setup there is the need to set the default gateway to the additional interface defined via the multus annotations. To allow this a user can configure ipam.gateway in the NAD. EnsureNetworksAnnotation() will override the pod network default route by reading the NAD. If ipam.gateway is defined and not "", it gets set on the networks annotation as the default-route.

Jira: https://issues.redhat.com/browse/OSPRH-8680

Depends-On: https://github.com/openstack-k8s-operators/lib-common/pull/579

stuggi commented 5 hours ago

/retest

openshift-ci[bot] commented 4 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/horizon-operator/blob/main/OWNERS)~~ [abays,stuggi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment