openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Log when *ImageMatch functions return false #1003

Closed dprince closed 1 month ago

dprince commented 1 month ago

This adds Log.Info statements when the images do not match up which can help pin-point debugging.

If the service contains a single image both images are logged if there is a mismatch. To keep code more readable for multi-container services only a simple log message is added in the case of a mismatch (still useful enough to pin-point an issue).

dprince commented 1 month ago

motivation for this change was https://issues.redhat.com/browse/OSPCIX-414

Adding this logging help pinpoint the service that was hitting an issue (Telemetry)

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [abays,dprince] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

New changes are detected. LGTM label has been removed.

softwarefactory-project-zuul[bot] commented 1 month ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8964c16257df47b2b94a4744ac0c960f

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 1h 50m 56s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 08s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 11m 26s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 1h 37m 31s

abays commented 1 month ago

recheck

abays commented 1 month ago

@dprince: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Required Rerun command ci/prow/openstack-operator-build-deploy-kuttl 177bb9a link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Removing debug pod ...
error: unable to upgrade connection: container container-00 not found in pod oko-11-r6n7q-master-0-debug-jzgzw_openstack
make: *** [Makefile:565: crc_storage] Error 1

/test openstack-operator-build-deploy-kuttl