search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Default to global spec.secret like other service do #1005

Closed stuggi closed 1 month ago

stuggi commented 1 month ago

Most of the service default to spec.secret if the service.spec.secret is not provided. This adds it to those services which not yet did that.

This should probably be moved to be done in the webhook, but for now this gets it in sync with the current implementation of the other services

stuggi commented 1 month ago

I don't think Heat has this either, can we also add for Heat?

just missed to save the file , thanks for the pointer

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, bshephar, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [abays,bshephar,stuggi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
abays commented 1 month ago

@stuggi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Required Rerun command ci/prow/openstack-operator-build-deploy-kuttl a6b809b link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Removing debug pod ...
error: unable to upgrade connection: container container-00 not found in pod oko-18-8l7tf-master-0-debug-jzdwq_openstack-kuttl-tests
make[3]: *** [Makefile:562: crc_storage_cleanup] Error 1

/test openstack-operator-build-deploy-kuttl