search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Share ApacheImage with baremetal, octavia, and telemetry #1009

Closed dprince closed 1 month ago

dprince commented 1 month ago

The same http image is already used for these services but is causing bundle warnings at build time. This change updates the OpenStackVersion resource so that a single Apache parameter is shared by Baremetal, Octavia, and Telemetry.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [dprince] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dprince commented 1 month ago

@jlarriba @beagles how does this look?

dprince commented 1 month ago

This PR was a blocker for https://github.com/openstack-k8s-operators/openstack-operator/pull/1012 . I've now rebased 1012 to include this. If CI passes I may just use the larger PR as folks don't seem to get the motivation for these changes.

jlarriba commented 4 weeks ago

It was holiday, not motivation, which made this PR unreviewed. Im sorry about that, but I see that the changes were already merged in the other PR.

Thank you @dprince