search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
30 stars 77 forks source link

Unmarshal values from AnsibleVarsFrom as json #1028

Closed slagle closed 2 months ago

slagle commented 2 months ago

Instead of assuming that the ansible vars in a configmap or secret used with AnsibleVarsFrom are just string key/value pairs, support json values. This is needed to support variables such as edpm_container_registry_logins with AnsibleVarsFrom.

To maintain backwards compatiblity with any already created ConfigMaps or Secrets, if the unmarshalling to JSON fails, a plain string value is assumed.

Jira: https://issues.redhat.com/browse/OSPRH-9500 Signed-off-by: James Slagle jslagle@redhat.com

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [fao89,slagle] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slagle commented 2 months ago

/cherry-pick 18.0.0-proposed

openshift-cherrypick-robot commented 2 months ago

@slagle: new pull request created: #1033

In response to [this](https://github.com/openstack-k8s-operators/openstack-operator/pull/1028#issuecomment-2309934126): >/cherry-pick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.