Picking DNSDataLabelSelectorValue from DNSMasq struct

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack

https://openstack-k8s-operators.github.io/openstack-operator/

Apache License 2.0

27 stars 76 forks source link

Picking DNSDataLabelSelectorValue from DNSMasq struct #1038

Closed jpodivin closed 4 weeks ago

jpodivin commented 1 month ago

It may have been cleaner to get the dnsmasq struct right before the DNSData is created, but it would involve duplicating all the checks in checkDNSService, since we are already using that to fill field in DNSDetails it feels like reasonable thing to use it for selector as well.

That being said, moving to alternative is trivial.

jpodivin commented 1 month ago

/retest

openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, jpodivin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [bshephar,jpodivin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment