search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Return error when IPSet not found #1063

Closed rabi closed 2 weeks ago

rabi commented 2 weeks ago

We now use IPAM by default and if there are IPSet for a node missing we should return an error rather than ignoring it.

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [jpodivin,rabi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rabi commented 1 week ago

/cherrypick 18.0.0-proposed

openshift-cherrypick-robot commented 1 week ago

@rabi: new pull request created: #1087

In response to [this](https://github.com/openstack-k8s-operators/openstack-operator/pull/1063#issuecomment-2362722167): >/cherrypick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.