openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Use RestartPolicy: Never for the jobs #1082

Closed rabi closed 1 week ago

rabi commented 1 week ago

With RestartPolicy: OnFailure new pods are not created[1], but the containers in esiting pod are restarted. We were using RestartPolicy: Never with openstack-ansibleee-operator. This was changed when we switched to drop it's usage.

[1] https://kubernetes.io/docs/concepts/workloads/controllers/job/#handling-pod-and-container-failures

softwarefactory-project-zuul[bot] commented 1 week ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a467455cfe224798a7663d18126e426f

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 4h 01m 05s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 56s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 44s :x: openstack-operator-tempest-multinode FAILURE in 1h 08m 51s

softwarefactory-project-zuul[bot] commented 1 week ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/61698aaaa5914ea69b780c20d2aae603

:x: openstack-k8s-operators-content-provider POST_FAILURE in 1h 33m 50s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 01s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 20m 57s :x: openstack-operator-tempest-multinode FAILURE in 1h 07m 29s

fao89 commented 1 week ago

recheck

softwarefactory-project-zuul[bot] commented 1 week ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/50a6007abadb4b2cab76c0524e9c562c

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 03m 07s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 56s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 08s :x: openstack-operator-tempest-multinode FAILURE in 1h 08m 50s

rabi commented 1 week ago

recheck

stuggi commented 1 week ago

I think you'd have to rebase to get https://github.com/openstack-k8s-operators/openstack-operator/pull/1084 ?

rabi commented 1 week ago

I think you'd have to rebase to get #1084 ?

I think we pull the PR on top of latest main in jobs.

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, rabi, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [fao89,rabi,slagle] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment