Rebuild ManilaShares list

[fmount]

We're currently not able to trigger a shareCleanup reconciliation loop when the top-level CR is updated and a ManilaShare entry is removed. In the effort of adding the shareCleanup feature in [1], we need to fix the openstack-operator code to rebuild a fresh version of ManilaShares from the existing CR. Similarly to Cinder [2], this also fixes a regression for users who wants multiple shares with different backends after the initial deployment.

Jira: https://issues.redhat.com/browse/OSPRH-6525

[1] https://github.com/openstack-k8s-operators/manila-operator/pull/79 [2] https://github.com/openstack-k8s-operators/openstack-operator/commit/ede5a0645f17b2b5e4a06ac8c660f9cdd7507424

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ca36e8fd59c845aa84f2eb4454f73acb

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 11m 36s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 57s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 08s :x: openstack-operator-tempest-multinode FAILURE in 1h 09m 41s

[fmount]

/test openstack-operator-build-deploy-kuttl

[fmount]

recheck

[stuggi]

I think you'd have to rebase to get https://github.com/openstack-k8s-operators/openstack-operator/pull/1084 ?

[fmount]

I think you'd have to rebase to get #1084 ?

aah makes sense! thank you!

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/45843f905aa648f884a74f07e2c11130

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 3h 17m 08s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 11s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 22m 04s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 1h 43m 15s

[fmount]

recheck

[fmount]

Tested locally and I can see the new reconciliation loop being triggered now when we delete a share.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, jpodivin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [jpodivin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[fmount]

/test openstack-operator-build-deploy-kuttl