search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Removing unused control plane default structure and funcs #1086

Closed jpodivin closed 6 days ago

jpodivin commented 1 week ago

The code has been implemented a while ago, and we have moved on since then. Contents of the structure weren't actually used to set default values of the resource spec. Originally I wanted to leave the SetupDefaults stub. Although it doesn't do anything right now, there may be a time when we can develop it into something useful. But we can do that anyway, start from scratch.

jpodivin commented 1 week ago

/retest

error: must build at directory: not a valid directory: evalsymlink failure on '/alabama/install_yamls/out/openstack-kuttl-tests/swift/cr' : lstat /alabama/install_yamls/out/openstack-kuttl-tests/swift: no such file or directory

dprince commented 1 week ago

These probably haven't been used since we added OpenStackVersion

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, jpodivin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [dprince,jpodivin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment