Drop EEJobInterface

[rabi]

It's not used anywhere. If we've multiple structs implementing the same methods, we can have an interface and call the methods on the interface.

[rabi]

/test openstack-operator-build-deploy-kuttl

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/95446dc101a44acf8d764214bc3f8040

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 1h 58m 06s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 40m 38s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 42m 40s :x: openstack-operator-tempest-multinode FAILURE in 1h 45m 16s

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/36ffaf3ff7874892a96f0e9d9f733b7b

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 1h 50m 10s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 05s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 08s :x: openstack-operator-tempest-multinode FAILURE in 1h 37m 08s

[rabi]

recheck

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7c4fa79a1659443aa975969ff5757389

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 1h 49m 51s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 23s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 25m 03s :x: openstack-operator-tempest-multinode FAILURE in 1h 36m 52s

[rabi]

recheck RETRY_LIMIT

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/76fe7eeaa6b4471bbb7858ee4e660d27

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 1h 51m 48s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 43s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 24m 01s :x: openstack-operator-tempest-multinode FAILURE in 1h 38m 55s

[jpodivin]

recheck

Openshift marketplace failure Some core CRC pods are not ready...

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6f87dda765d445a1a566e9981ca91d10

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 1h 47m 43s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 12s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 21m 54s :x: openstack-operator-tempest-multinode FAILURE in 1h 35m 44s

[jpodivin]

Tempest test: testtools.matchers._impl.MismatchError: 'compute-2.ctlplane.example.com' != 'compute-1.ctlplane.example.com': Live Migration failed. Migrations list for Instance 1fb75314-c0fa-46d4-a74c-46fd594e7804

https://logserver.rdoproject.org/88/1088/ccf6020aaeedd50bc3e4d3d209ef67ee4d19f232/github-check/openstack-operator-tempest-multinode/a5c8f4a/controller/ci-framework-data/tests/test_operator/tempest-tests/stestr_results.html

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, jpodivin, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [bshephar,jpodivin,rabi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[rabi]

Yeah, I was thinking about using it for some tests, but I never ended up implementing it. Should have dropped it from my original PR, my bad.

Unless multiple structs implement the same interface, you don't need them. Also, it was hiding the fact that addEnvFrom() is not called at all and linter was not complaining.

[rabi]

recheck