search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
30 stars 77 forks source link

Restoring lost defaults for ansible env vars #1089

Closed jpodivin closed 1 month ago

jpodivin commented 1 month ago

EnvConfigMapName used to default to openstack-aee-default-env, which is a config map we use[0] in install-yamls. After the merger of ansibleeeoperator with the openstack operator, we have lost this (and other) defaults, since the new EEJob struct is only an internal representation and not a resource for customers to modify.

Going forward we have essentially two options.

  1. Restore the default for the config map name. Allowing us to create and modify it, in order to change ansibleee behavior.
  2. Remove the EnvConfigMapName field entirely, as it is effectively unused.

Should we go with option 1. the obvios next step would be to allow modifications to the field value. In order to substitute alternative configuration in a simpler fashion. We could put that field in the OpenStackDataPlaneDeployment for example.

[0] https://github.com/openstack-k8s-operators/install_yamls/blob/main/devsetup/edpm/config/ansible-ee-env.yaml

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, jpodivin, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [fao89,jpodivin,slagle] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
abays commented 1 month ago

@jpodivin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Required Rerun command ci/prow/openstack-operator-build-deploy-kuttl 9ca9b3d link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

error: unable to upgrade connection: container container-00 not found in pod oko-07-pv78l-master-2-debug-7t985_openstack-kuttl-tests

/test openstack-operator-build-deploy-kuttl