search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Use OCP registries.conf for disconnected deployments #1098

Open bshephar opened 1 week ago

bshephar commented 1 week ago

This change adds functionality to check for ImageContentSourcePolicy in the OCP cluster. If we find it, we infer from its existance that we are running in a disconnected OCP deployment. If this is indeed the case, we will pull the registries.conf file from the MachineConfig and use this for our dataplane nodes configured via edpm_ansible.

Jira: https://issues.redhat.com/browse/OSPRH-10303

openshift-ci[bot] commented 1 week ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [bshephar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
softwarefactory-project-zuul[bot] commented 1 week ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e8213e8c350b4364ab4ac62a0ee7ffb8

:x: openstack-k8s-operators-content-provider FAILURE in 6m 08s :warning: podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

bshephar commented 1 week ago

Go 1.21 and release-4.16 allowed me to use the MachineConfig CRD from openshift/api which we already have a dependency on: https://github.com/openshift/api/blob/release-4.16/machineconfiguration/v1/types.go#L301

So, we will need to wait until the Go upgrade PR merges before we look at this one. It should reduce the size of the PR once that other one is merged.

softwarefactory-project-zuul[bot] commented 1 week ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cfc691e9ff9c4970b378636c6585bb6f

:x: openstack-k8s-operators-content-provider FAILURE in 6m 07s :warning: podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul[bot] commented 1 week ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6b8b7773a66e4fe3bcf2190ded00344b

:x: openstack-k8s-operators-content-provider FAILURE in 6m 14s :warning: podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul[bot] commented 6 days ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8021dd8aea2a4581b161da67352e7806

:x: openstack-k8s-operators-content-provider FAILURE in 6m 29s :warning: podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul[bot] commented 5 days ago

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging github.com/openstack-k8s-operators/openstack-operator for 1098,d140d1e4aaba515baadbc244e7ac2241ac7c8947

softwarefactory-project-zuul[bot] commented 5 days ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1931afa5922d47b7b50ca0fc1b899856

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 39m 15s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 40m 15s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 40m 34s :x: adoption-standalone-to-crc-ceph-provider FAILURE in 2h 28m 04s :x: openstack-operator-tempest-multinode FAILURE in 1h 42m 39s

bshephar commented 5 days ago

/hold

softwarefactory-project-zuul[bot] commented 5 days ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1b42f3a50b0d42abb9f6ebccb1e122c0

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 37m 11s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 37m 08s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 37m 29s :x: adoption-standalone-to-crc-ceph-provider FAILURE in 2h 25m 08s :x: openstack-operator-tempest-multinode FAILURE in 1h 44m 01s

softwarefactory-project-zuul[bot] commented 5 days ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6b18f497c609462ab6cdd9017bbddb70

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 49m 15s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 39m 03s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 41m 03s :x: adoption-standalone-to-crc-ceph-provider FAILURE in 2h 26m 52s :x: openstack-operator-tempest-multinode FAILURE in 1h 44m 47s

softwarefactory-project-zuul[bot] commented 4 days ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f7e741955b384a79b7916ca9451f78b0

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 1h 55m 00s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 38m 28s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 36m 51s :x: adoption-standalone-to-crc-ceph-provider FAILURE in 1h 29m 31s :x: openstack-operator-tempest-multinode FAILURE in 1h 43m 13s

softwarefactory-project-zuul[bot] commented 4 days ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/620d717d369a4e0c8fa4c3d8973b4820

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 37m 12s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 39m 08s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 37m 07s :x: adoption-standalone-to-crc-ceph-provider FAILURE in 2h 25m 46s :x: openstack-operator-tempest-multinode FAILURE in 1h 44m 54s

bshephar commented 4 days ago

Failure is:

❯ curl -s "https://logserver.rdoproject.org/98/1098/0ef0806ac21876cddc079be6c4a6d8f4d70dca6c/github-check/podified-multinode-edpm-deployment-crc/ecd5596/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/crs/openstackdataplanenodesets.dataplane.openstack.org/openstack-edpm-ipam.yaml" | yq ".status.conditions[0]"
lastTransitionTime: "2024-09-26T04:21:07Z"
message: NodeSetDNSDataReady error occurred DNSData.network.openstack.org "openstack-edpm-ipam" not found
reason: Error
severity: Error
status: "False"
type: Ready

It does indeed appear to be there: https://logserver.rdoproject.org/98/1098/0ef0806ac21876cddc079be6c4a6d8f4d70dca6c/github-check/podified-multinode-edpm-deployment-crc/ecd5596/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/crs/dnsdata.network.openstack.org/

Need to dig deeper to see if this is somehow related. But initial look appears to not be related.

❯ curl -s "https://logserver.rdoproject.org/98/1098/0ef0806ac21876cddc079be6c4a6d8f4d70dca6c/github-check/podified-multinode-edpm-deployment-crc/ecd5596/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/crs/dnsdata.network.openstack.org/openstack-edpm-ipam.yaml" | yq .status.conditions
- lastTransitionTime: "2024-09-26T04:21:07Z"
  message: Setup complete
  reason: Ready
  status: "True"
  type: Ready
- lastTransitionTime: "2024-09-26T04:21:07Z"
  message: Input data complete
  reason: Ready
  status: "True"
  type: ServiceConfigReady
softwarefactory-project-zuul[bot] commented 3 days ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/05748cab4dc44c3eb0dcdef358448b89

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 3h 10m 17s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 39m 09s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 43m 03s :x: adoption-standalone-to-crc-ceph-provider FAILURE in 2h 29m 50s :x: openstack-operator-tempest-multinode FAILURE in 1h 46m 49s

softwarefactory-project-zuul[bot] commented 3 days ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/35109bb3cd1b4a49b087a955e076e07d

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 39m 15s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 39m 38s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 1h 39m 06s :x: adoption-standalone-to-crc-ceph-provider FAILURE in 2h 27m 00s :x: openstack-operator-tempest-multinode FAILURE in 1h 44m 00s

softwarefactory-project-zuul[bot] commented 2 days ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/eeadda38a4324d23a8e9a6e0a4e94ba6

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 19m 23s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 42m 02s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 21s :x: adoption-standalone-to-crc-ceph-provider FAILURE in 1h 30m 26s :x: openstack-operator-tempest-multinode FAILURE in 1h 45m 01s

bshephar commented 7 hours ago

/retest

bshephar commented 7 hours ago

recheck

openshift-ci[bot] commented 6 hours ago

@bshephar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl 234554af3d9503f3f193c79e09498748dc973cc5 link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
softwarefactory-project-zuul[bot] commented 5 hours ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/06d408df0a9d41a48af23213f348d537

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 38m 23s :x: podified-multinode-edpm-deployment-crc FAILURE in 1h 38m 20s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 21m 38s :x: adoption-standalone-to-crc-ceph-provider FAILURE in 2h 26m 13s :x: openstack-operator-tempest-multinode FAILURE in 1h 43m 57s