Reapply "[ovn-controller] Don't create ovn-controller if nicMappings"

[averdagu]

This is the same patch that was merged a couple of days ago (seen on PR#1070). This commit blocked adoption gates so it got reverted (on PR#1103), more information about problem on the description.

Recreating PR to be able to test changes done in ovn-operator (PR#352) while we fix the error uncover with this patch.

Depends-on: https://github.com/openstack-k8s-operators/ovn-operator/pull/352

https://github.com/openstack-k8s-operators/openstack-operator/pull/1070 https://github.com/openstack-k8s-operators/openstack-operator/pull/1103 https://github.com/openstack-k8s-operators/ovn-operator/pull/352

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/35784b204bcc4f0fbe05418d765a9550

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 3h 09m 14s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 49s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 27s :x: openstack-operator-tempest-multinode FAILURE in 1h 50m 14s

[averdagu]

recheck

[booxter]

The patch is ok but we'll need to wait for the ovn-operator part to land first.

[booxter]

     logger.go:42: 11:01:36 |  | Error from server (InternalError): error when creating "https://raw.githubusercontent.com/openstack-k8s-operators/infra-operator/main/config/samples/network_v1beta1_netconfig.yaml": Internal error occurred: failed calling webhook "mnetconfig.kb.io": failed to call webhook: Post "https://infra-operator-controller-manager-service.openstack-operators.svc:443/mutate-network-openstack-org-v1beta1-netconfig?timeout=10s": no endpoints available for service "infra-operator-controller-manager-service" 

[booxter]

/retest-required

[averdagu]

Kuttl tests failed with: logger.go:42: 18:57:46 | ctlplane-tls-custom-issuers/7- | nova-internal.openstack-kuttl-tests.svc:8774 issued by , expected issuer=CN=rootca-internal It seems a valid error but should not be affected by this patch, will recheck again to see if it was a one-time error (also on previous patches kuttl test didn't fail IIRC). PS: Since ovn-operator patch was already merged, will try to run an adoption test to make sure it won't break (again) the gate.

[averdagu]

/retest-required

[booxter]

FYI ctlplane-tls-custom-issuers is failing quite frequently and probably has nothing to do with your PR per se.

[booxter]

The latest run at https://review.rdoproject.org/r/c/testproject/+/54746 is green and confirms this PR no longer breaks adoption gate (after Arnau moved -config generation to OVNDbCluster controller).

[slawqo]

This looks good for me and we should be good to go with it now

[karelyatin]

/lgtm

[fao89]

/approve

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: averdagu, booxter, fao89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [fao89] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[booxter]

Again, ctlplane-tls-custom-issuers failed

[booxter]

/retest-required

[averdagu]

/retest-required