search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
30 stars 77 forks source link

we should not default to any iamge form the redhat regeistry as the operators shoudl be deployable without a pull secret #235

Closed SeanMooney closed 1 year ago

SeanMooney commented 1 year ago

https://github.com/openstack-k8s-operators/openstack-operator/blob/be3d3c851b83ce01e7f0f4cf8a9bf13e764901f1/pkg/openstack/rabbitmq.go#L81

we shoudl not be defaulting to images form the redhat registry for any service images

they should be using the image from tripleo/tcib/quay

this should be using quay.io/tripleozedcentos9/openstack-rabbitmq:current-tripleo

until we swap to using the new tcib images.

SeanMooney commented 1 year ago

the new tcib image is here quay.io/podified-zed-centos9/openstack-rabbitmq:current-podified

dprince commented 1 year ago

I have actually brought up the idea that we do a lot more of this. As this is mostly a RH project ATM and we only use OpenShift one could take the position that a pull secret is a fine requirement.

That said I'm open to using a new container image for rabbit assuming it matches the downstream requirements (interfaces). @jeckersb is there such an image?

In the meantime, this project isn't tracking things in github issues/aside from Renovatebot. So going to close this and we can follow up with a Jira.

jeckersb commented 1 year ago

That said I'm open to using a new container image for rabbit assuming it matches the downstream requirements (interfaces). @jeckersb is there such an image?

We should be able to use pretty much any rabbitmq image as long as it's recent enough to support all of the configuration options that the operator expects to be present. The upstream rabbitmq image obviously works fine, as does the OSP17 downstream image, but the OSP16 one is too old. I am assuming that the podified-zed-centos9 image @SeanMooney mentioned above is new enough that it could be used without issue.

If you check out the changes where this got added in https://github.com/openstack-k8s-operators/openstack-operator/pull/37 you'll see that I actually had to modify a few oddball things in the operator related to logging as well as the container Args to point to the location in the OSP17 image where the rabbitmq binary is located. The logging things don't really matter either way, but the Args value will probably need to either have the default changed, or be explicitly overridden to match the layout of a different image.