openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
30 stars 77 forks source link

Bump dataplane-operator #747

Closed rabi closed 7 months ago

rabi commented 7 months ago

To include tlse fix https://github.com/openstack-k8s-operators/dataplane-operator/pull/812

jira: https://issues.redhat.com/browse/OSPRH-6266

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [abays] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
abays commented 7 months ago

@rabi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Required Rerun command ci/prow/openstack-operator-build-deploy-kuttl b32bbbc link unknown /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

/test openstack-operator-build-deploy-kuttl

Keystone hit the DBSync error that @zzzeek is looking into (and might be fixing via [1]):

    message: 'DBsync job error occurred Internal error occurred: Job Failed. Check
      job logs'

[1] https://github.com/openstack-k8s-operators/mariadb-operator/pull/216

karelyatin commented 7 months ago

May be can take https://github.com/openstack-k8s-operators/openstack-operator/pull/746 instead as contains other updates too

abays commented 7 months ago

May be can take #746 instead as contains other updates too

Cool. #746 has passed CI and should be merged soon.

karelyatin commented 7 months ago

/hold

Let's hold it than as taking other one, if that merges other one will get delayed.

rabi commented 7 months ago

@karelyatin Looks like https://github.com/openstack-k8s-operators/openstack-operator/pull/746 has failed. This one is green. Are we going to followup with that or merge this?

zzzeek commented 7 months ago

/test openstack-operator-build-deploy-kuttl

Keystone hit the DBSync error that @zzzeek is looking into (and might be fixing via [1]):

    message: 'DBsync job error occurred Internal error occurred: Job Failed. Check
      job logs'

[1] openstack-k8s-operators/mariadb-operator#216

Right so most of what we'd want to see here, like the "successful" db create job, isn't preserved, I'm really wanting to see the output of that job / pod specifically. I've looked at the status of galera matched with the time the MariaDBDatabase CR had it's job complete, and the CR shows job completion one second before all three galera nodes were synced, which doesnt say much as logs can be off by one second and it could have been using a synced node. the PR I have would hopefully fix any "silent failure" problems at least since it does a positive check that the database / account got created.

karelyatin commented 7 months ago

@karelyatin Looks like #746 has failed. This one is green. Are we going to followup with that or merge this?

there is issue with prow, ci team is checking. will unhold this and see if this merges and rebase the other one.

karelyatin commented 7 months ago

/unhold