openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
30 stars 77 forks source link

Remove networkAttachment for ovnNorthd #759

Closed umago closed 6 months ago

umago commented 7 months ago

ovnNorthd does not require additional interface via networkAttachment, this patch removes it from the sample files.

openshift-ci[bot] commented 7 months ago

Hi @umago. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
karelyatin commented 7 months ago

/ok-to-test

booxter commented 7 months ago

/lgtm

softwarefactory-project-zuul[bot] commented 7 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a3c17290712f4ec8a20ac2e4d2e3bff6

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 15m 46s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 19s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 20s :x: openstack-operator-tempest-multinode FAILURE in 1h 38m 20s

karelyatin commented 7 months ago

recheck live migration tests

/lgtm

booxter commented 7 months ago

Removed "Closes" tag since we need an ovn-operator PR too.

umago commented 7 months ago

Removed "Closes" tag since we need an ovn-operator PR too.

Good point! Let me get rid of that tag

booxter commented 7 months ago

/lgtm

booxter commented 7 months ago

/approve

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: booxter, dprince, stuggi, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [dprince,stuggi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dprince commented 6 months ago

/override ci/prow/openstack-operator-build-deploy-kuttl

openshift-ci[bot] commented 6 months ago

@dprince: Overrode contexts on behalf of dprince: ci/prow/openstack-operator-build-deploy-kuttl

In response to [this](https://github.com/openstack-k8s-operators/openstack-operator/pull/759#issuecomment-2071166758): >/override ci/prow/openstack-operator-build-deploy-kuttl Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.