openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
30 stars 77 forks source link

Add type label to osctlplane object #760

Closed stuggi closed 7 months ago

stuggi commented 7 months ago

Adds map[string]string{"core.openstack.org/openstackcontrolplane": ""} to the instance, if not already provided in the CR. With this ctlplane object can be queried using the default label. Which is useful e.g. in tests to query the ctlplane in a generic way without the object name.

stuggi commented 7 months ago

useful to do something like this oc wait openstackcontrolplane -n <namespace> --for condition=Ready --timeout <timeout> -l <label>

softwarefactory-project-zuul[bot] commented 7 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e2c2bb992be940609a358775f15ede45

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 07m 39s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 31s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 22m 00s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 1h 35m 07s

stuggi commented 7 months ago

recheck

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [dprince,stuggi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment