openshift-ci[bot]
commented
7 months ago [APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: abays, fmount, gibizer
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
- ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [abays]
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
We placed the RestoreLastTransitionTimes before we decide if the ReadyCondition needs to be set to True or not. This causes that the lastTransitionTime of the ReadyCondition changes even if nothing is actually changed during the reconciliation. The OpenStackControlPlane and OpenStackVersion resources watching each other creating a reconcile loop.
This change moves the RestoreLastTransitionTimes to happen after the ReadyCondition status is finally set.