Version: Create helper before manipulating instance

[gibizer]

The helper.NewHelper creates snapshot of the instance being reconciled and PatchInstance at the end of the reconcile loop uses this to generate the Patch to persist the changes done by the reconciler. Therefore the helper needs to be created before any changes on the instance. This is fixed now to avoid loosing in memory changes.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [stuggi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/df202e3e91a14a7f845c363707dffb03

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 43m 37s :x: podified-multinode-edpm-deployment-crc FAILURE in 22m 06s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 19m 42s :x: openstack-operator-tempest-multinode FAILURE in 25m 13s

[gibizer]

recheck

2024-04-25 08:59:19.745130 | controller | TASK [cert_manager : Install cert-manager cmctl CLI src=https://github.com/cert-manager/cert-manager/releases/{{ cifmw_cert_manager_version }}/download/cmctl-linux-amd64.tar.gz, dest={{ lookup('env', 'HOME') }}/bin/, remote_src=True] ***
2024-04-25 08:59:19.745135 | controller | Thursday 25 April 2024  08:59:19 -0400 (0:00:00.210)       0:03:01.266 ********
2024-04-25 08:59:20.584914 | controller | fatal: [localhost]: FAILED! => {"changed": false, "msg": "Invalid archive '/home/zuul/.ansible/tmp/ansible-tmp-1714049959.7881033-31093-186532232218769/cmctl-linux-amd64lin3yeu3.tar.gz', the file is 0 bytes"}

[stuggi]

recheck

2024-04-25 08:59:19.745130 | controller | TASK [cert_manager : Install cert-manager cmctl CLI src=https://github.com/cert-manager/cert-manager/releases/{{ cifmw_cert_manager_version }}/download/cmctl-linux-amd64.tar.gz, dest={{ lookup('env', 'HOME') }}/bin/, remote_src=True] ***
2024-04-25 08:59:19.745135 | controller | Thursday 25 April 2024  08:59:19 -0400 (0:00:00.210)       0:03:01.266 ********
2024-04-25 08:59:20.584914 | controller | fatal: [localhost]: FAILED! => {"changed": false, "msg": "Invalid archive '/home/zuul/.ansible/tmp/ansible-tmp-1714049959.7881033-31093-186532232218769/cmctl-linux-amd64lin3yeu3.tar.gz', the file is 0 bytes"}

fyi, from slack, its a known issue worked on here https://github.com/openstack-k8s-operators/ci-framework/pull/1568

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1403339d31044a5ab8eedf3285371ac8

:x: openstack-k8s-operators-content-provider POST_FAILURE in 42m 44s :x: podified-multinode-edpm-deployment-crc POST_FAILURE in 19m 31s :x: cifmw-crc-podified-edpm-baremetal POST_FAILURE in 19m 28s :x: openstack-operator-tempest-multinode POST_FAILURE in 23m 03s

[stuggi]

recheck