openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
30 stars 77 forks source link

sub resource ready condition updates/fixes #787

Closed dprince closed 5 months ago

dprince commented 6 months ago

Now that all service operators have been updated we can check observed generation here before setting the ready condition of the subresource.

Jira: OSPRH-5698 Jira: OSPRH-6112

fmount commented 6 months ago

/retest

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [dprince] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
gibizer commented 6 months ago

/hold Do we need this for beta?

fmount commented 6 months ago

ah, I'm not sure about that, best to check w/ @dprince, otherwise we can merge it after beta freeze

dprince commented 6 months ago

merging after beta freeze is fine. The Jira's here are targetted GA

softwarefactory-project-zuul[bot] commented 6 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9a0954f000ab4c54b3f5384189915d56

:x: openstack-k8s-operators-content-provider FAILURE in 17m 09s :warning: podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

dprince commented 5 months ago

recheck

fmount commented 5 months ago

/lgtm