openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

update config samples to include default cell template #829

Closed SeanMooney closed 3 months ago

SeanMooney commented 3 months ago

This change updates the config samples to inculde the cells templates so that the default behavior fo the cell 1 creation can be modifed in the future without impacting docs or ci jobs.

currently cell 0 and 1 are created by nova by default in a feture operator version we plannign to remove the automatic creation of cell 1 so that the procedure ot add the first and subsequent comptue cells are identical.

gibizer commented 3 months ago

We also need to modify https://github.com/openstack-k8s-operators/architecture/blob/27ee3f78472aa65107d4f1b3c6f8fb4a3dd2fa4f/lib/control-plane/openstackcontrolplane.yaml#L151 before we remove the defaulting from the nova-operator

SeanMooney commented 3 months ago

We also need to modify https://github.com/openstack-k8s-operators/architecture/blob/27ee3f78472aa65107d4f1b3c6f8fb4a3dd2fa4f/lib/control-plane/openstackcontrolplane.yaml#L151 before we remove the defaulting from the nova-operator

ah good point. we don't need to rush to remove the defaulting however ill submit a patch to the architecture repo for that too

SeanMooney commented 3 months ago

We also need to modify https://github.com/openstack-k8s-operators/architecture/blob/27ee3f78472aa65107d4f1b3c6f8fb4a3dd2fa4f/lib/control-plane/openstackcontrolplane.yaml#L151 before we remove the defaulting from the nova-operator

ah good point. we don't need to rush to remove the defaulting however ill submit a patch to the architecture repo for that too

done in https://github.com/openstack-k8s-operators/architecture/pull/272

SeanMooney commented 3 months ago

/test openstack-operator-build-deploy-kuttl

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: gibizer, SeanMooney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment