openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
30 stars 77 forks source link

Move ctlplane tests to ctlplane dir #844

Closed fao89 closed 5 months ago

fao89 commented 5 months ago

It will reduce the conflicts on https://github.com/openstack-k8s-operators/openstack-operator/pull/765 when PRs get merged

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fao89 Once this PR has been reviewed and has the lgtm label, please assign lewisdenny for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
fao89 commented 5 months ago

@dprince I believe this is the core of the conflict between https://github.com/openstack-k8s-operators/openstack-operator/pull/792 and https://github.com/openstack-k8s-operators/openstack-operator/pull/765

I extracted this into this PR, because I had to rebase https://github.com/openstack-k8s-operators/openstack-operator/pull/765 every time a PR with tests is merged

fao89 commented 5 months ago

/test openstack-operator-build-deploy-kuttl

softwarefactory-project-zuul[bot] commented 5 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d70994bc94f84305a03130321431e35f

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 38m 19s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 44s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 36m 09s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 1h 46m 41s

fao89 commented 5 months ago

recheck

dprince commented 5 months ago

one inline nit, otherwise looks good

softwarefactory-project-zuul[bot] commented 5 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5ee18953b79042798387c7a4722d4c3d

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 25m 46s :x: podified-multinode-edpm-deployment-crc RETRY_LIMIT in 24m 23s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 12s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 1h 44m 35s

stuggi commented 5 months ago

this has not run the kuttl tests - https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openstack-k8s-operators_openstack-operator/844/pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl/1801031141696737280/artifacts/openstack-operator-build-deploy-kuttl/openstack-k8s-operators-kuttl/build-log.txt

=== CONT  kuttl/harness/ctlplane
    logger.go:42: 23:55:31 | ctlplane | Ignoring ctlplane-basic-deployment as it does not match file name regexp: ^(\d+)-(?:[^\.]+)(?:\.yaml)?$
    logger.go:42: 23:55:31 | ctlplane | Ignoring ctlplane-collapsed as it does not match file name regexp: ^(\d+)-(?:[^\.]+)(?:\.yaml)?$
    logger.go:42: 23:55:31 | ctlplane | Ignoring ctlplane-galera-3replicas as it does not match file name regexp: ^(\d+)-(?:[^\.]+)(?:\.yaml)?$
    logger.go:42: 23:55:31 | ctlplane | Ignoring ctlplane-galera-basic as it does not match file name regexp: ^(\d+)-(?:[^\.]+)(?:\.yaml)?$
    logger.go:42: 23:55:31 | ctlplane | Skipping creation of user-supplied namespace: openstack-kuttl-tests
    logger.go:42: 23:55:31 | ctlplane | skipping kubernetes event logging
fao89 commented 5 months ago

closing as https://github.com/openstack-k8s-operators/openstack-operator/pull/765 is passing now