openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
24 stars 67 forks source link

Drop DataPlaneService ConfigMaps and Secrets #852

Closed fao89 closed 1 week ago

fao89 commented 2 weeks ago

Copied: https://github.com/openstack-k8s-operators/dataplane-operator/pull/923

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [fao89] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
fao89 commented 2 weeks ago

I don't agree with dropping of the labels, at very least not all of them. There is still need for fine grained resource selection and I don't think removing labels supporting that is especially useful.

I just copied @slagle PR, but I believe the labels were removed because it didn't have a standard among the services. I think we can add labels using the webhook, this way we would ensure a standard

softwarefactory-project-zuul[bot] commented 2 weeks ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9274fbc28b08495f80193b2b32ec6f63

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 1h 30m 39s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 32s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 13m 32s :x: openstack-operator-tempest-multinode RETRY_LIMIT in 12m 59s :heavy_check_mark: openstack-operator-docs-preview SUCCESS in 2m 02s

rabi commented 1 week ago

Needs a rebase after the docs patch it seems.

rabi commented 1 week ago

/lgtm