openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Introducing spec level validation of dataplane/controlplane TLS consistency #853

Closed jpodivin closed 3 months ago

jpodivin commented 3 months ago

Verifies that TLS settings for nodeset are consistent with those of existing control plane, if there is one and only one.

If there are multiple control planes the process will result in error, same if it isn't possible to retrieve list of control planes.

Tests are included

I'm porting this now to the joint repo.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [jpodivin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/75c65b5d2cc2418b8bd8b789554877ac

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 3h 11m 12s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 16s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 10m 10s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 1h 50m 20s

jpodivin commented 3 months ago

recheck

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/186ef8bf613f4b9291bc3d7daaa2624c

:x: openstack-k8s-operators-content-provider FAILURE in 10m 08s :warning: podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

jpodivin commented 3 months ago

/retest

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ca8c4d7eea4b4aa392a325f5d320c754

:x: openstack-k8s-operators-content-provider FAILURE in 11m 07s :warning: podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/7ede96f53a0d410a984e752e9f22413e

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 29m 48s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 38s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 8m 21s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 1h 50m 57s

jpodivin commented 3 months ago

/recheck

jpodivin commented 3 months ago

recheck

Deydra71 commented 2 months ago

@jpodivin Hi! I'm curious why this has been closed.