search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
24 stars 67 forks source link

Remove the deployed attribute from deployment #860

Closed rabi closed 1 week ago

rabi commented 1 week ago

We reset the conditions and deployed: false for every reconcile now and code to check the deployed flag during reconcile is not relevant and dead code.

We have also made the deployment spec immutable which won't allow for any changes to the spec.

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [fao89,rabi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rabi commented 1 week ago

/test openstack-operator-build-deploy-kuttl

fao89 commented 1 week ago

/test openstack-operator-build-deploy-kuttl