search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
24 stars 67 forks source link

Cinder: Fix `cinderVolumes` changes #870

Closed Akrog closed 1 week ago

Akrog commented 1 week ago

A regression was introduced on the handling of the cinderVolumes on commit 4930eed3380bc945279173c989d1a4c95cdda90e.

The current code is not able to remove entries from the cinderVolumes section so backends cannot be removed and they cannot be renamed.

When we try to remove a volume backend, the volume remains in the existing Cinder CR. And when we try to rename a volume backend, we end up with 2 backends in the Cinder CR, one with the old name and one with the new name.

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Akrog, ASBishop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment