search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
24 stars 67 forks source link

Dedupe services to be deployed for nodeset #881

Open rabi opened 1 week ago

rabi commented 1 week ago

Jira: https://issues.redhat.com/browse/OSPRH-8104

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [rabi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rabi commented 6 days ago

Marking WIP to add functional tests.

rabi commented 6 days ago

/test openstack-operator-build-deploy-kuttl

softwarefactory-project-zuul[bot] commented 6 days ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/cee782a66b9242aab5c479b2bffeadd2

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 3h 35m 11s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 21s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT Host unreachable in 10m 24s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 1h 45m 36s

slagle commented 4 days ago

Is this something you view as blocker for GA? It was shared in the podified call yesterday that "We should consider ourselves in blockers-only mode at this point". If we intend to proceed with this for GA, it should likely have an associated blocking Jira.

rabi commented 4 days ago

Is this something you view as blocker for GA?

I think this is a good UX improvement. I was not aware of the decision and also started this before Tuesday's podified call. Are we applying this rule for all PRs as I notice PRs[1] merged yesterday without blocker flags? Having said that, if we think we should not merge this before GA, it can wait.

[1] https://github.com/openstack-k8s-operators/openstack-operator/pull/847

slagle commented 4 days ago

Is this something you view as blocker for GA?

I think this is a good UX improvement. I was not aware of the decision and also started this before Tuesday's podified call. Are we applying this rule for all PRs as I notice PRs[1] merged yesterday without blocker flags? Having said that, if we think we should not merge this before GA, it can wait.

[1] #847

we can check with @cmsj, the guidance came from him

rabi commented 3 days ago

error: build error: Failed to push image: trying to reuse blob sha256:e394ea8406c7ed85ddc862f882ec77dcfd3863de3cb90fd8006238d521d22d44 at destination: pinging container registry quay.rdoproject.org: Get "https://quay.rdoproject.org/v2/": dial tcp 38.129.56.158:443: i/o timeout

rabi commented 3 days ago

/test openstack-operator-build-deploy-kuttl

jpodivin commented 3 days ago

The code has +2 from me, even though we can't merge it right away. Couple of things to consider in the meantime.

rabi commented 3 days ago

even though we can't merge it right away.

Why is that (as discussed yesterday we're not in blocker only mode yet and this is an UX improvement)? As per documentation is concerned, we need to just document that:

I'll will do a doc only follow-up next week.