openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
24 stars 67 forks source link

Validate galera templates storageRequest via validation webhook #882

Closed stuggi closed 5 days ago

stuggi commented 1 week ago

Notify the enduser if the configured DB storageRequest is too low for production use. It is not blocking to allow lower settings for test/ci systems. The output would be like:

$ oc apply -n openstack -f core_v1beta1_openstackcontrolplane_galera_network_isolation_3replicas.yaml
Warning: spec.galera.template[openstack-cell1].storageRequest: 1G is not appropriate for production! For production use at least 5G!
Warning: spec.galera.template[openstack].storageRequest: 500M is not appropriate for production! For production use at least 5G!

Depends-On: https://github.com/openstack-k8s-operators/lib-common/pull/522 Depends-On: https://github.com/openstack-k8s-operators/mariadb-operator/pull/234

softwarefactory-project-zuul[bot] commented 1 week ago

This change depends on a change that failed to merge.

Changes https://github.com/openstack-k8s-operators/lib-common/pull/522, https://github.com/openstack-k8s-operators/mariadb-operator/pull/234 are needed.

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [abays,stuggi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
softwarefactory-project-zuul[bot] commented 6 days ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/fe46947e5f6045b9b330ae8d321601f6

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 15m 50s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 20s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 09m 24s :x: cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 36m 57s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 1h 48m 43s

stuggi commented 6 days ago

recheck

abays commented 6 days ago

/retest