openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Standardize config manager defaults #883

Closed yazug closed 2 months ago

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yazug Once this PR has been reviewed and has the lgtm label, please assign bshephar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yazug commented 3 months ago

Another advantage is that we can see up front if there are any warning from operator-sdk when generating the bundle. Currently there are 3 warnings that are only visible in the bundle creation job but likely missed or glossed over.

WARN[0002] warning: multiple related images with the same image ref, "aodh-api-image-url-default", and different names found.The image will only be listed once with an empty name.It is recmmended to either remove the duplicate or use the exact same name. WARN[0002] warning: multiple related images with the same image ref, "apache-image-url-default", and different names found.The image will only be listed once with an empty name.It is recmmended to either remove the duplicate or use the exact same name. WARN[0002] warning: multiple related images with the same image ref, "infra-dnsmasq-image-url-default", and different names found.The image will only be listed once with an empty name.It is recmmended to either remove the duplicate or use the exact same name.

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/473517a199824bc799008c41a71e56b3

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 55m 30s :x: podified-multinode-edpm-deployment-crc FAILURE in 36m 34s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 33m 39s :x: openstack-operator-tempest-multinode FAILURE in 41m 56s

openshift-ci[bot] commented 3 months ago

@yazug: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl a319373d2d78fcf17161266caea4225d4a47fbe1 link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3438cde6dca24463857a2ef1ad706cd9

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 55m 58s :x: podified-multinode-edpm-deployment-crc FAILURE in 36m 46s :x: cifmw-crc-podified-edpm-baremetal FAILURE in 31m 52s :x: openstack-operator-tempest-multinode FAILURE in 41m 01s

dprince commented 2 months ago

@yazug I pushed a PR https://github.com/openstack-k8s-operators/openstack-operator/pull/928 that has these changes (rebased) and also simplifies how bundles are built by getting rid of csv_merger