search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Create all default services #896

Closed slagle closed 3 months ago

slagle commented 3 months ago

Instead of only creating the default services that are in a NodeSet's Spec.Services, create all default services. Since we support ServicesOverride on a Deployment, we should create all default services in case any of those default services are used on a Deployment but aren't listed in a NodeSet's Spec.Services.

This applies directly to the update related services (ovn-update, update) since those are used with ServicesOverride.

Jira: https://issues.redhat.com/browse/OSPRH-7957 Signed-off-by: James Slagle jslagle@redhat.com

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [bshephar,slagle] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
fao89 commented 3 months ago

/test openstack-operator-build-deploy-kuttl