search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Cleanup apiOverrides when a GlanceAPI is removed from ctlplane #903

Closed fmount closed 2 months ago

fmount commented 3 months ago

Currently, if a GlanceAPI is added to the ctlplane and then removed, the human operator needs to manually clean up the Glance section in the ctlplane CR and remove the generated APIOverrides. In addition to that, overrides are generated regardless of the nature of the glanceAPI (e.g. Edge, that is not supposed to have any Route as only an internal Svc is provided). This patch solves this problem by removing the (leftover) overrides for the APIs that are no longer present in the ctlplane CR.

Jira: OSPRH-8072

fmount commented 2 months ago

/test openstack-operator-build-deploy-kuttl

stuggi commented 2 months ago

looks good to me, thanks

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [stuggi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment