search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Adding patch rbac perm for serviceaccounts #909

Closed jpodivin closed 2 months ago

jpodivin commented 2 months ago

Resolves: https://issues.redhat.com/browse/OSPRH-8363

gibizer commented 2 months ago

/hold until we branch to 18.0.0-proposed

stuggi commented 2 months ago

can you please add wherever we have update, but not patch, also the patch?

bshephar commented 2 months ago

I tried to push to this PR branch, but it didn't love it. It just created a new branch on this repo. But this is the additional changes @stuggi is talking about I believe: https://github.com/openstack-k8s-operators/openstack-operator/commit/2c7a889d18c963379a8c95d9e8df927fb1c99dba

I'll leave the branch there for now if you just want to cherry-pick it and squash with the existing change on this PR.

stuggi commented 2 months ago

I tried to push to this PR branch, but it didn't love it. It just created a new branch on this repo. But this is the additional changes @stuggi is talking about I believe: 2c7a889

I'll leave the branch there for now if you just want to cherry-pick it and squash with the existing change on this PR.

yes correct, thanks @bshephar

stuggi commented 2 months ago

I tried to push to this PR branch, but it didn't love it. It just created a new branch on this repo. But this is the additional changes @stuggi is talking about I believe: 2c7a889 I'll leave the branch there for now if you just want to cherry-pick it and squash with the existing change on this PR.

yes correct, thanks @bshephar

@jpodivin @bshephar I have cherry-picked and squashed the two commits.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, fmount, gibizer, jpodivin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [bshephar,jpodivin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
stuggi commented 2 months ago

/cherry-pick 18.0.0-proposed

openshift-cherrypick-robot commented 2 months ago

@stuggi: once the present PR merges, I will cherry-pick it on top of 18.0.0-proposed in a new PR and assign it to you.

In response to [this](https://github.com/openstack-k8s-operators/openstack-operator/pull/909#issuecomment-2210477280): >/cherry-pick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 2 months ago

@stuggi: new pull request created: #911

In response to [this](https://github.com/openstack-k8s-operators/openstack-operator/pull/909#issuecomment-2210477280): >/cherry-pick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.