search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Use Red Hat Logo #914

Closed bshephar closed 2 months ago

bshephar commented 2 months ago

This changes swaps out the OpenStack logo for the Red Hat one

dprince commented 2 months ago

Kind of sad to see it go. But Lgtm. Thanks @bshephar

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, bshephar, dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [abays,bshephar,dprince] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
softwarefactory-project-zuul[bot] commented 2 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/48e41daa48934227844dec1372fea0d5

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 23m 07s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 20s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 19m 58s :x: openstack-operator-tempest-multinode FAILURE in 1h 36m 42s

rh-jelabarre commented 2 months ago

My one question here is how would you check if the logo renders correctly (that there isn't anything wrong in the base64data) without having to do a full deploy?

bshephar commented 2 months ago

My one question here is how would you check if the logo renders correctly (that there isn't anything wrong in the base64data) without having to do a full deploy?

In an automated way? Or manually?

I think it would be difficult to do in an automated way. You would need to render it, then check a specific pixel matches the expected output I guess. But manually is easy:

❯ yq '.spec.icon[].base64data' config/manifests/bases/openstack-operator.clusterserviceversion.yaml | base64 -d > test-the-image.png

Then just opening the image.

bshephar commented 2 months ago

recheck

fao89 commented 2 months ago

you can copy the CSV here: https://operatorhub.io/preview

bshephar commented 2 months ago

/test openstack-operator-build-deploy-kuttl

compi-migui commented 1 month ago

/cherry-pick 18.0.0-proposed

openshift-cherrypick-robot commented 1 month ago

@compi-migui: only openstack-k8s-operators org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to [this](https://github.com/openstack-k8s-operators/openstack-operator/pull/914#issuecomment-2301374738): >/cherry-pick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
compi-migui commented 1 month ago

/cherry-pick 18.0.0-proposed

openshift-cherrypick-robot commented 1 month ago

@compi-migui: new pull request created: #1017

In response to [this](https://github.com/openstack-k8s-operators/openstack-operator/pull/914#issuecomment-2301387410): >/cherry-pick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.