search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
30 stars 77 forks source link

Drop csv merger #928

Closed dprince closed 3 months ago

dprince commented 4 months ago

With this change the RELATED_IMAGES for all service operators are all listed (and ordered) with the openstack-operators. Use of the csv_merger is dropped and bundle generation is greatly simplified as a result.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [dprince] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yazug commented 4 months ago

This should help with OSPRH-8398

yazug commented 4 months ago

kuttle failing with the following, which appears to be the warnings I was seeing before with duplicate related images mapping to the same image and having weird naming or empty name

time="2024-07-11T17:54:33Z" level=fatal msg="Error generating bundle manifests: failed to set related images: bundle/manifests/openstack-operator.clusterserviceversion.yaml - Found conflicts when setting relatedImages:\nrelatedImage : quay.io/podified-antelope-centos9/openstack-aodh-api@sha256:7cdfa816e5228fa4ef2e68989f1ecfb8eea2c0930897bda222f6f3d387a6548f X relatedImage : registry.redhat.io/ubi9/httpd-24@sha256:7830b8d73168bcdec441141392bbfd4f3e4c7715bc0cefd3d9ef456767608917\nrelatedImage : quay.io/podified-antelope-centos9/openstack-aodh-api@sha256:7cdfa816e5228fa4ef2e68989f1ecfb8eea2c0930897bda222f6f3d387a6548f X relatedImage : quay.io/podified-antelope-centos9/openstack-ovn-controller@sha256:1930e5f63a0ad8b35d3038537f649c49a7669d75271c4d89c629f429db518305\nrelatedImage : quay.io/podified-antelope-centos9/openstack-aodh-api@sha256:7cdfa816e5228fa4ef2e68989f1ecfb8eea2c0930897bda222f6f3d387a6548f X relatedImage : quay.io/podified-antelope-centos9/openstack-neutron-server@sha256:cc23ff0d2413d5fde5cb46a644d1523b9a97538d13c2328c2d76d6835f683879"

dprince commented 4 months ago

I was aware of the warnings, but didn't realize they would cause kuttle test errors.

@yazug this telemetry-operator PR should fix 2 of those errors: https://github.com/openstack-k8s-operators/telemetry-operator/pull/440

I will look at the rest...

openshift-ci[bot] commented 3 months ago

@dprince: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl a436ef538dafd1008a602bb8717e9d009a35de46 link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dprince commented 3 months ago

Trying to do this in parts isn't getting traction. I pushed the complete PR here: https://github.com/openstack-k8s-operators/openstack-operator/pull/1012