search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
30 stars 77 forks source link

[rabbitmq] remove CommonName from tls cert #934

Closed stuggi closed 4 months ago

stuggi commented 4 months ago

The CommonName has a max length of 64 bytes. Since the CommonName value is already in the DnsNames of the certificate it is not required.

Jira: https://issues.redhat.com/browse/OSPRH-8652

stuggi commented 4 months ago

manually tested in a fips enabled env that rabbitmq properly starts and services connect.

lmiccini commented 4 months ago

seems to be fine for FIPS so it should be OK.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [olliewalsh,stuggi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
olliewalsh commented 4 months ago

/cherry-pick 18.0.0-proposed

openshift-cherrypick-robot commented 4 months ago

@olliewalsh: new pull request created: #940

In response to [this](https://github.com/openstack-k8s-operators/openstack-operator/pull/934#issuecomment-2229487122): >/cherry-pick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.