search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
30 stars 77 forks source link

Adding UI descriptors to select bool flags #945

Closed jpodivin closed 4 months ago

jpodivin commented 4 months ago

The booleanSwitch descriptor [0] gives us easy way to make our resources more responsive through Console UI. We are already using it for other component sections, so setting it for Horizon only normalizes the use.

The DeployOnAllNodeSets field of the service is a trickier case. But I can imagine situations when fast switch to global could be useful for debugging. That being said, I don't feel that strongly about it.

[0] https://github.com/openshift/console/blob/master/frontend/packages/operator-lifecycle-manager/src/components/descriptors/reference/reference.md#4-booleanswitch

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, jpodivin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [fao89,jpodivin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jpodivin commented 4 months ago

/retest