openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
30 stars 77 forks source link

[validation] check galera instance names are valid #952

Closed stuggi closed 3 months ago

stuggi commented 4 months ago

The galera controller creates StatefulSet for the db to run. This adds a StatefulSet pod's label "controller-revision-hash": "-" to the pod. The kubernetes label is restricted under 63 char and the revision hash is an int32, 10 chars + the hyphen. The galera controller also adds a suffix '-galera' to the statefulset name. With this the max name must not exceed 46 chars.

Also the name of the created galera instance must match a lowercase RFC 1123.

Depends-On: https://github.com/openstack-k8s-operators/lib-common/pull/532 Depends-On: https://github.com/openstack-k8s-operators/mariadb-operator/pull/246

Jira: https://issues.redhat.com/browse/OSPRH-8063

softwarefactory-project-zuul[bot] commented 4 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/48bfd5da3c1e43968372d39a2d0d1702

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 3h 10m 56s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 01s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 15s :x: cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 57m 24s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 2h 03m 05s

stuggi commented 4 months ago

recheck

softwarefactory-project-zuul[bot] commented 4 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/cbcb74e787034bd28362b4d252878cd0

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 55m 34s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 31s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 21m 07s :heavy_check_mark: cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 30m 34s :x: openstack-operator-tempest-multinode FAILURE in 29m 57s

stuggi commented 4 months ago

recheck

softwarefactory-project-zuul[bot] commented 4 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/867b5f4f0b084cfcaa71bcfacbf4d481

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 45m 53s :x: podified-multinode-edpm-deployment-crc FAILURE in 27m 22s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 18m 49s :heavy_check_mark: cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 30m 28s :x: openstack-operator-tempest-multinode FAILURE in 28m 57s

stuggi commented 4 months ago

recheck

stuggi commented 4 months ago

recheck

softwarefactory-project-zuul[bot] commented 4 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/f18154d67a1a4833941e11f7c932e3e8

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 3h 10m 51s :x: podified-multinode-edpm-deployment-crc FAILURE in 25m 14s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 23s :heavy_check_mark: cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 41m 33s :x: openstack-operator-tempest-multinode FAILURE in 28m 38s

stuggi commented 4 months ago

recheck

softwarefactory-project-zuul[bot] commented 4 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/19d891adf14047eebb2cb5ca31ab0bd6

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 42m 32s :x: podified-multinode-edpm-deployment-crc FAILURE in 25m 24s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 33s :heavy_check_mark: cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 27m 06s :x: openstack-operator-tempest-multinode FAILURE in 28m 07s

stuggi commented 3 months ago

recheck

softwarefactory-project-zuul[bot] commented 3 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a92c00fdb4d64353b721e1f97247efc8

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 4h 07m 46s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 16s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 10m 26s :heavy_check_mark: cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 31m 30s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 2h 11m 33s

openshift-ci[bot] commented 3 months ago

New changes are detected. LGTM label has been removed.

stuggi commented 3 months ago

rebased

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, gibizer, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [abays,stuggi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment