openshift-ci[bot]
commented
2 months ago [APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: abays, gibizer, stuggi
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
- ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [abays,stuggi]
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
softwarefactory-project-zuul[bot]
stuggi
The glanceAPI controller creates StatefulSet for glanceapi to run. This adds a StatefulSet pod's label "controller-revision-hash": "-" to the pod.
The kubernetes label is restricted under 63 char and the revision hash is an int32, 10 chars + the hyphen. Which results in a default statefulset max len of 52 chars. The statefulset name also contain the glance name and the glanceAPI type + 2 hyphens. So the max len also need to be reduced bye the length of those.
Also the name of the created rabbitmq instance must match a lowercase RFC 1123.
Depends-On: openstack-k8s-operators/lib-common#532 Depends-On: https://github.com/openstack-k8s-operators/glance-operator/pull/587
Jira: https://issues.redhat.com/browse/OSPRH-8063