search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
30 stars 77 forks source link

[validation] check cinderVolumes names are valid #957

Closed stuggi closed 3 months ago

stuggi commented 4 months ago

CinderVolume name is -volume- The CinderVolume controller creates StatefulSet for volume service to run. This adds a StatefulSet pod's label "controller-revision-hash": "-" to the pod. The kubernetes label is restricted under 63 char and the revision hash is an int32, 10 chars + the hyphen. Which results in a default statefulset max len of 52 chars. The statefulset name also contain the cinder name and -volume-. So the max len also need to be reduced bye the length of those.

Also the name of the created cinderVolume name match a lowercase RFC 1123.

Depends-On: openstack-k8s-operators/lib-common#532 Depends-On: https://github.com/openstack-k8s-operators/cinder-operator/pull/420 Jira: https://issues.redhat.com/browse/OSPRH-8063

stuggi commented 4 months ago

need to rebase after https://github.com/openstack-k8s-operators/openstack-operator/pull/955

softwarefactory-project-zuul[bot] commented 4 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a40185a188b9428490767728e14a81b3

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 3h 17m 36s :x: podified-multinode-edpm-deployment-crc FAILURE in 25m 26s :heavy_check_mark: cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 19m 51s :heavy_check_mark: cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 33m 07s :x: openstack-operator-tempest-multinode FAILURE in 28m 44s

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [abays,stuggi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment