openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Add edpm_service_types #962

Closed slagle closed 2 months ago

slagle commented 2 months ago

The list of service types is added as an ansible variable to the inventory as edpm_service_types. This will be used instead of edpm_services since service names could be any customer values.

edpm-ansible roles such as edpm_update, need a list of consistent service identifiers (types instead of names), so it knows which other roles to include for update tasks.

Jira: https://issues.redhat.com/browse/OSPRH-8107 Signed-off-by: James Slagle jslagle@redhat.com

softwarefactory-project-zuul[bot] commented 2 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/40f9846fa6e14be08ed834ad388081dc

:x: openstack-k8s-operators-content-provider FAILURE in 9m 03s :warning: podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

slagle commented 2 months ago

/retest

softwarefactory-project-zuul[bot] commented 2 months ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1352d879b70646f79483867eb3503376

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 06m 05s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 54s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 10m 30s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 1h 51m 07s

slagle commented 2 months ago

should we also get the serviceOverride list? https://github.com/openstack-k8s-operators/openstack-operator/blob/main/pkg/dataplane/util/ansible_execution.go#L127-L135

do you mean something like edpm_service_override_types? I don't have a specific use case for that right now. but we can add it in a follow up.

fao89 commented 2 months ago

should we also get the serviceOverride list? https://github.com/openstack-k8s-operators/openstack-operator/blob/main/pkg/dataplane/util/ansible_execution.go#L127-L135

do you mean something like edpm_service_override_types? I don't have a specific use case for that right now. but we can add it in a follow up.

yeah, I was curious if you had a use case for it

fao89 commented 2 months ago

recheck

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, jpodivin, rebtoor, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [fao89,jpodivin,rebtoor,slagle] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slagle commented 2 months ago

/cherrypick 18.0.0-proposed

openshift-cherrypick-robot commented 2 months ago

@slagle: new pull request created: #969

In response to [this](https://github.com/openstack-k8s-operators/openstack-operator/pull/962#issuecomment-2245276739): >/cherrypick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.