[OSPRH-8473] Warning: unknown field "spec.telemetry.template.logging.…

[jlarriba]

…network"

[snecklifter]

@jlarriba rather than just remove the line, would it be possible to replace it with an annotation example?

[jlarriba]

@snecklifter I dont think I like that idea: the annotations are configured exactly identical in all the operators (we are all reusing the same framework) and none of the rest have them in these examples. I think the idea is to try to keep the yaml example files not too verbose. The annotation usage could be documented in the official documentation, in a common section.

[jlarriba]

Sorry, i have realized that there are actually examples where they have them. We could do it to show that there is that possibility. I am going definitively to add the annotations field to some of the samples.

[abays]

Sorry, i have realized that there are actually examples where they have them. We could do it to show that there is that possibility. I am going definitively to add the annotations field to some of the samples.

It looks good to me. Should we wait for this additional change before approving?

[jlarriba]

Sorry, i have realized that there are actually examples where they have them. We could do it to show that there is that possibility. I am going definitively to add the annotations field to some of the samples.

It looks good to me. Should we wait for this additional change before approving?

Yes please

[jlarriba]

@abays now its ready

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, jlarriba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [abays] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/0e72da6a5a8e4ea7a34a27dee68cea21

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 14m 45s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 47s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 9m 44s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 1h 52m 29s

[jlarriba]

recheck

[softwarefactory-project-zuul[bot]]

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://review.rdoproject.org/zuul/buildset/40f1ddf57df54ca7b2e6a1aa3d1d45c5

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 1h 49m 49s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 57s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 10m 14s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 1h 34m 35s

[jlarriba]

recheck

[jlarriba]

/test openstack-operator-build-deploy-kuttl

[jlarriba]

/test openstack-operator-build-deploy-kuttl