search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Don't reconcile for status updates #968

Closed rabi closed 2 months ago

rabi commented 2 months ago

We do nodeset/deployment status update very frequently and reconciling them again after every status update is expensive. This also sometimes leads to infinite loops and results in very verbose controller logs.

Also removes the changes to duplicate multating webhook logic when calling CreateOrPatch() from EnsureServices().

rabi commented 2 months ago

/test openstack-operator-build-deploy-kuttl

abays commented 2 months ago

I tested this with VA1 and the deployment succeeded, and the OpenStack operator logs did not endlessly cycle with reconciliation loops.

:+1:

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [abays,rabi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment