search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Revert "Remove the deployed attribute from deployment" #970

Closed slagle closed 2 months ago

slagle commented 2 months ago

This reverts commit 5a55c47a24fca6ac76ca08c72f9a0c69913379d9.

Without the status.Deployed boolean flag on OpenStackDataPlaneDeployment there is no mechanism in place to prevert the full reconcile of a Deployment. While the immutable annotation prevents user edits to the spec, other changes could still trigger Deployment reconciles.

In the case of testing minor updates, it was discovered that when the ansible runner image as specified by the RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT env var in the openstack-operator csv is changed, it will re-execute the ansible for all existing Deployments. This breaks the minor update workflow as things are done out of order, and breaks the expectation that it is the user who starts ansible executions as opposed to automatically.

Jira: OSPRH-8923 Signed-off-by: James Slagle jslagle@redhat.com

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciecierski, fao89, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [fao89,slagle] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slagle commented 2 months ago

/cherrypick 18.0.0-proposed

openshift-cherrypick-robot commented 2 months ago

@slagle: new pull request created: #971

In response to [this](https://github.com/openstack-k8s-operators/openstack-operator/pull/970#issuecomment-2248833548): >/cherrypick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.