openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Use ansibleEE library instead of AnsibleEE v1 CR #972

Closed bshephar closed 2 weeks ago

bshephar commented 2 months ago

This change swaps out the use of the AnsibleEE custom resource for a generic Go library implementation. This enables us to stop using the unnecessary OpenStackAnsibleEE abstraction that we currently have around Kubernetes Jobs for AnsibleEE executions.

Jira: https://issues.redhat.com/browse/OSPRH-8926

bshephar commented 1 month ago

/test openstack-operator-build-deploy-kuttl

softwarefactory-project-zuul[bot] commented 1 month ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/36cf103e99704254a9c19da3dab63dfe

:x: openstack-k8s-operators-content-provider FAILURE in 10m 28s :warning: podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

bshephar commented 1 month ago

/test openstack-operator-build-deploy-kuttl

softwarefactory-project-zuul[bot] commented 1 month ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0eba841817714945ad4215bebfebfbfe

:x: openstack-k8s-operators-content-provider FAILURE in 8m 53s :warning: podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

bshephar commented 1 month ago

/test openstack-operator-build-deploy-kuttl

bshephar commented 1 month ago

/test openstack-operator-build-deploy-kuttl

bshephar commented 1 month ago

/test openstack-operator-build-deploy-kuttl

bshephar commented 1 month ago

/test openstack-operator-build-deploy-kuttl

softwarefactory-project-zuul[bot] commented 1 month ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a192bf5615dc454b9b8492e6ca03cc10

:x: openstack-k8s-operators-content-provider NODE_FAILURE Node request 100-0007556581 failed in 0s :warning: podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

jpodivin commented 1 month ago

/recheck

node failure

jpodivin commented 1 month ago

recheck

softwarefactory-project-zuul[bot] commented 1 month ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/26abccfc19bc4c53a512d15e856abaf2

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 2h 15m 04s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 11s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 26m 00s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 1h 32m 07s

bshephar commented 1 month ago

recheck

bshephar commented 1 month ago

/test openstack-operator-build-deploy-kuttl

bshephar commented 3 weeks ago

/test openstack-operator-build-deploy-kuttl

bshephar commented 3 weeks ago

/test openstack-operator-build-deploy-kuttl

bshephar commented 3 weeks ago

/test openstack-operator-build-deploy-kuttl

bshephar commented 3 weeks ago

/test openstack-operator-build-deploy-kuttl

bshephar commented 3 weeks ago

/retest-required

softwarefactory-project-zuul[bot] commented 2 weeks ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c5a51331398f44c780df58ad6829e5dc

:heavy_check_mark: openstack-k8s-operators-content-provider SUCCESS in 1h 55m 05s :heavy_check_mark: podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 14s :x: cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 21m 37s :heavy_check_mark: openstack-operator-tempest-multinode SUCCESS in 1h 40m 56s

bshephar commented 2 weeks ago

recheck

softwarefactory-project-zuul[bot] commented 2 weeks ago

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3fcaaf93f1984609b949078d6856fbda

:x: openstack-k8s-operators-content-provider FAILURE in 5m 03s :warning: podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider :warning: openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

bshephar commented 2 weeks ago

recheck

bshephar commented 2 weeks ago

+2, could be refactored further to change some of the functions from GetAnsibleExecution to GetEEJob etc. Also, remove some of the comments like https://github.com/openstack-k8s-operators/openstack-operator/blob/main/pkg/dataplane/util/ansible_execution.go#L41.

Yeah, the file could use some work. I have another branch with some refactoring here: https://github.com/openstack-k8s-operators/openstack-operator/commit/dae8a7090dd28bb417a57d05e4ba514ef78cf9f1

Once this one merges, I'll be able to tidy it up and send that branch as a PR to clean up the rest of it. This PR was already too big and too many changes, so I left any additional refactoring for another PR.

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, fao89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [bshephar,fao89] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
fao89 commented 2 weeks ago

/hold

fao89 commented 2 weeks ago

hold wasn't feast enough 😓 I wanted to double-check first if we could merge it, but the bot was faster

bshephar commented 2 weeks ago

It was ready. I have some further refactoring in another branch. So I'll send that and we can make any additional adjustments as part of that PR.