search

openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Restore LastTransitionTime after setting Ready Condition #979

Closed rabi closed 2 months ago

rabi commented 2 months ago

instance.Status.Conditions.MarkTrue() always sets the current time as the LastTransitionTime and this results in infinite loop as the LastTransitionTime changes after every reconcile.

We don't see the issue at times as the next reconcile is probably too quick to not change the LastTransitionTime(precision for which is in seconds). The issue showed up in dataplane controllers as we reconcile a number of services in a loop for every reconcile of nodeset.

This seems to have been changed in other controllers of this operator with https://github.com/openstack-k8s-operators/openstack-operator/pull/768.

Jira: OSPRH-8811

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/main/OWNERS)~~ [fao89,rabi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
stuggi commented 2 months ago

/test openstack-operator-build-deploy-kuttl

rabi commented 2 months ago

/cherrypick 18.0.0-proposed

openshift-cherrypick-robot commented 2 months ago

@rabi: new pull request created: #980

In response to [this](https://github.com/openstack-k8s-operators/openstack-operator/pull/979#issuecomment-2253693620): >/cherrypick 18.0.0-proposed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.