openstack-k8s-operators / openstack-operator

Meta Operator for OpenStack
https://openstack-k8s-operators.github.io/openstack-operator/
Apache License 2.0
27 stars 76 forks source link

Update to latest lib-common from 18.0.0-proposed #989

Closed slagle closed 3 weeks ago

slagle commented 1 month ago

For consistency, all modules from lib-common are updated to their latest versions from the 18.0.0-proposed branch.

lib-common was updated due to https://issues.redhat.com/browse/OSPRH-9089 https://github.com/openstack-k8s-operators/lib-common/pull/545

Jira: OSPRH-9161 Signed-off-by: James Slagle jslagle@redhat.com

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openstack-k8s-operators/openstack-operator/blob/18.0.0-proposed/OWNERS)~~ [slagle] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
softwarefactory-project-zuul[bot] commented 1 month ago

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging github.com/openstack-k8s-operators/openstack-operator for 989,8a16159e4218a82e06ac6b0804d8b27f0d5c969c

openshift-ci[bot] commented 1 month ago

@slagle: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/precommit-check 78607f5937cc5618ffe2a83f144f3dbbbf819450 link true /test precommit-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
bshephar commented 4 weeks ago

@slagle I can't push to this branch for some reason. Can you pre-commit run --all-files? Seems like it actually needs to be done twice. First time does operator-lint things, which then needs another go mod tidy. Easier to just run pre-commit twice and push the changes I think.

slagle commented 3 weeks ago

@slagle I can't push to this branch for some reason. Can you pre-commit run --all-files? Seems like it actually needs to be done twice. First time does operator-lint things, which then needs another go mod tidy. Easier to just run pre-commit twice and push the changes I think.

I'll close this. We decided that updating all the lib-common modules wasn't necessary.